一次典型的重构

Background Description:

The author decided to refactor a C# program calculating arithmetic expressions as an example for an upcoming talk on refactoring. The original code computed expressions with brackets and four arithmetic operations. The program was simplified by removing brackets, assuming the first character is a digit, and considering only valid expressions.

Refactoring Techniques Used:

1. Renaming Variables: The original program used abbreviated pinyin for variable names, making them hard to understand. The refactored code uses meaningful English names.
2. Extracting Methods: The original code used one large method, while the refactored code is split into four methods, improving understandability and reusability.
3. Extracting Classes: A new class was introduced to encapsulate the calculation methods.
4. Algorithm Optimization: The original logic was inconsistent and complicated, especially in handling multiplication and division.
5. Correcting Logical Errors: The original program had hidden logical errors, evident when inputting expressions like "3*3/3/3".
6. Adding Simple Comments: The original program lacked comments.

Original Code:

The original code is provided, showing a lack of clarity in variable naming and structure. It uses a single method to handle all operations and lacks comments.

Refactored Code:

The refactored code introduces a new class with private members to store operators and numbers. It includes methods to divide the expression into operators and numbers, determine if a character is an operator, and rebuild the expression after each operation. The code handles multiplication and division first, followed by addition and subtraction. Clear variable names and structure are used to enhance readability and maintainability.

代码审查完整指南来了！

了解更多

想要了解更多内容？

查看原文：一次典型的重构

文章来源：

麦哲思科技任甲林

扫码关注公众号